Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in contrib-notes #375

Closed
wants to merge 1 commit into from
Closed

Fix broken links in contrib-notes #375

wants to merge 1 commit into from

Conversation

rakshithshenoy
Copy link

Signed-off-by: Rakshith Shenoy [email protected]

Closes #

Changes

  • There were quite a few broken links in the markdown files present in contrib-notes due to the absence of the ./ide-setup.md and ./release-process/weekly-qa-validation.md

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@rakshithshenoy
Fix broken links in contrib-notes
4998214 
Signed-off-by: Rakshith Shenoy <[email protected]>
@jeromesimeon jeromesimeon reopened this Feb 22, 2022
@jeromesimeon jeromesimeon self-requested a review February 22, 2022 21:56
jeromesimeon
jeromesimeon suggested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, two requested changes to the PR:

  1. one link does exist and should not be removed
  2. please revert changes to the package-lock.json file, unrelated to the PR

Thanks!

contrib-notes/coding-guidelines.md
@@ -1,9 +1,7 @@
# Contributing to Concerto
* [Step-by-step development environment setup](./getting-started.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove that link that seems to exist.

@jeromesimeon jeromesimeon mentioned this pull request Mar 1, 2022
Merged
@jeromesimeon
Copy link
Member

New PR for this is here: #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromesimeon jeromesimeon jeromesimeon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakshithshenoy @jeromesimeon