Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Typo #373

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Minor Typo #373

merged 4 commits into from
Jan 13, 2022

Conversation

AbhijithGanesh
Copy link
Contributor

@AbhijithGanesh AbhijithGanesh commented Jan 13, 2022 •
edited
Loading

Closes #

Changes

  • Changes typographic error

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@AbhijithGanesh
Copy link
Contributor Author

I shall sign it according to the standards

@mttrbrts
Copy link
Member

Good catch! There are some instructions here on how to fix the sign-off
https://github.com/accordproject/concerto/pull/373/checks?check_run_id=4798830007

@AbhijithGanesh
Copy link
Contributor Author

I will sign it off well, I am new to the ecosystem but I'll catch up :)

dselman and others added 4 commits January 13, 2022 17:41
@dselman
docs: update the module descriptions (accordproject#371)
3f30af6 
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Abhijith Ganesh <[email protected]>
@AbhijithGanesh
Minor Typo
5fd2170 
Signed-off-by: Abhijith Ganesh <[email protected]>
Revert "Minor Typo"
1d1a5fe 
This reverts commit c8d572d.

Signed-off-by: Abhijith Ganesh <[email protected]>
Minor Typo patch
c54841a 
Signed-off-by: Abhijith Ganesh <[email protected]>
@AbhijithGanesh
Copy link
Contributor Author

The DCO has been taken care of.

@mttrbrts
Copy link
Member

Thanks for the update @AbhijithGanesh. I'll merge it now. Although in future, please follow the guide here for rebasing. That helps to avoid conflicts with changes that happened since you last pulled down the code.
https://github.com/accordproject/techdocs/blob/master/CONTRIBUTING.md#-pull-request-submission-guidelines

@mttrbrts mttrbrts merged commit b3a1acb into accordproject:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhijithGanesh @mttrbrts @dselman