Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): set typescript enum values to strings (resolves #362) #363

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix(*): set typescript enum values to strings (resolves #362) #363

merged 1 commit into from
Dec 15, 2021

Conversation

sstone1
Copy link
Contributor

@sstone1 sstone1 commented Dec 15, 2021

Signed-off-by: Simon Stone [email protected]

Closes #

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

jeromesimeon
jeromesimeon approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeromesimeon jeromesimeon merged commit 8c84d75 into accordproject:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromesimeon jeromesimeon jeromesimeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstone1 @jeromesimeon