-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core+parser) Move CTO parser/printer out of core into its own package #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromesimeon
force-pushed
the
js-parser-package
branch
3 times, most recently
from
November 22, 2021 14:54
2e6b96e
to
88aac16
Compare
jeromesimeon
force-pushed
the
js-meta-parser
branch
2 times, most recently
from
November 22, 2021 17:16
e84e4e7
to
56060e0
Compare
jeromesimeon
force-pushed
the
js-parser-package
branch
9 times, most recently
from
November 24, 2021 20:49
eb436be
to
47d9d37
Compare
…kage Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon <[email protected]>
…kage Signed-off-by: jeromesimeon <[email protected]>
jeromesimeon
force-pushed
the
js-parser-package
branch
from
November 29, 2021 18:08
ea0d27e
to
85fc556
Compare
Signed-off-by: jeromesimeon <[email protected]>
jeromesimeon
force-pushed
the
js-parser-package
branch
from
November 29, 2021 19:10
215dbb3
to
3a42e10
Compare
…ic for reuse Signed-off-by: jeromesimeon <[email protected]>
jeromesimeon
force-pushed
the
js-parser-package
branch
from
November 30, 2021 21:31
413f27f
to
6977dd4
Compare
Signed-off-by: jeromesimeon <[email protected]>
jeromesimeon
force-pushed
the
js-parser-package
branch
from
December 1, 2021 14:48
a5a0d9b
to
6165d1c
Compare
jeromesimeon
changed the title
WIP(parser) Move CTO parser/printer out of core into its own package
refactor(core+parser) Move CTO parser/printer out of core into its own package
Dec 1, 2021
Signed-off-by: jeromesimeon <[email protected]>
dselman
requested changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - very clean! Just a couple of minor comments...
Signed-off-by: jeromesimeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jeromesimeon [email protected]
Changes
This PR reorganizes the core Concerto code and API and splits it into three distinct packages:
@accordproject/concerto-util
now contains utilities which are fundamentally generic and independent from Concerto itself. Currently those include:TypedStack
a general purpose stack data structureLogger
logging utility functions, with color supportWriter
a file writer*Loader
classes for resolving URIs into their content with some built-in support forhttp
andgit
URIs.@accordproject/concerto-cto
now contains support for CTO syntax including the parser, parse errors, and a pretty printer. The parser and pretty printer are base on instance of the concerto metamodel.@accordproject/concerto-core
the core support for building models (from instances of the metamodel) validating models, validating instances of the model, etcFlags
Main breaking changes
TypedStack
class has been moved from@accordproject/concerto-core
to@accordproject/concerto-util
Writer
class has been movedfrom@accordproject/concerto-core
to@accordproject/concerto-util
Logger
class has been moved from@accordproject/concerto-core
to@accordproject/concerto-util
*ModelFileLoader
classes have been moved from@accordproject/concerto-core
to@accordproject/concerto-util
and renamed to*FileLoader
(noModel
)ParseException
class have been moved from@accordproject/concerto-core
to@accordproject/concerto-cto
@accordproject/concerto-core
to@accordproject/concerto-cto
ModelFile
class now takes a metamodel instance (a concerto AST) as input rather than a cto stringconcerto import
andconcerto export
have been renamed toconcerto parse
andconcerto print