Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Typescript namespaces #348 #349

Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix: remove Typescript namespaces #348 #349

merged 1 commit into from
Nov 16, 2021

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Nov 15, 2021

Signed-off-by: Dan Selman [email protected]

Closes #348

  • Removes the Typescript namespaces

Changes

  • Updates Acorn to latest, so that JS code can use static class members
  • Updates eslint to latest so that the linter can check code with static class members

Flags

  • Once an unstable release is ready I will check it works with Typescript + Webpack in the context of a React project.

@dselman dselman requested a review from jeromesimeon November 15, 2021 12:44
@dselman dselman merged commit b8ab3e3 into master Nov 16, 2021
@dselman dselman deleted the ds-remove-ts-namespace branch November 16, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromesimeon jeromesimeon Awaiting requested review from jeromesimeon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use Concerto library in a Typescript project with Webpack
1 participant
@dselman