fix(build) Redo code coverage reporting, remove istanbul-combine #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jeromesimeon [email protected]
Description
Some recent builds are failing due to issues merging code coverage reporting. See e.g., https://github.com/accordproject/markdown-transform/runs/3924510479?check_suite_focus=true
In addition,
istanbul-combine
is not maintained and has known vulnerabilities.So I'm finally biting that bullet and re-doing the final code coverage reporting.
This is more painful than expected. One option would be to do a matrix for
coveralls
in the Github Actions and let coveralls do the merge.The option chosen here instead is to re-do the code coverage merge using:
./coverage
nyc
mergeChanges
instanbul-*
packages not maintained, failing and with vulnerabilitiesaxios
to latest versionFlags