chore(deps): move to uuid@8

[sstone1]

Currently installing the concerto-core module results in the following warning:

npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

This is because it depends on [email protected]. This change moves to [email protected].

Unfortunately the way the uuid module is written means that it is no longer possible to stub. To get the affected tests working again, I have added a new Factory.newId function that can be stubbed instead.

Signed-off-by: Simon Stone [email protected]

[jeromesimeon]

Thanks for the PR! Are you aware of any change in behavior between those two versions of uuid that we should be aware of or concerned about? [Since we mock the calls in test, not sure what we actually test there]

[jeromesimeon]

Looks great. Could you please add the corresponding method in the typescript interface as well?

concerto/packages/concerto-core/types/index.d.ts

Line 218 in cd3de6b

export class Factory {

[sstone1]

Looks great. Could you please add the corresponding method in the typescript interface as well?

concerto/packages/concerto-core/types/index.d.ts

Line 218 in cd3de6b

export class Factory {

@jeromesimeon I did! https://github.com/accordproject/concerto/pull/312/files#diff-e8048dc5a91e53453da6b9fc03e13c5a41d61435bc2e24fb3d05691999118b6cR219

I'm not aware of any differences in behaviour between the two versions, other than "more randomness".

[jeromesimeon]

Looks great. Could you please add the corresponding method in the typescript interface as well?

concerto/packages/concerto-core/types/index.d.ts

Line 218 in cd3de6b

export class Factory {

@jeromesimeon I did! https://github.com/accordproject/concerto/pull/312/files#diff-e8048dc5a91e53453da6b9fc03e13c5a41d61435bc2e24fb3d05691999118b6cR219

I'm not aware of any differences in behaviour between the two versions, other than "more randomness".

duh 🤦 😀

this is going in!

[jeromesimeon]

💯