fix(core) Properly handles flags in string regex validators #303

jeromesimeon · 2021-08-04T12:45:39Z

Signed-off-by: jeromesimeon [email protected]

Closes #302

Parser already supported them, but now string validation
With this fix, we can properly handle complex regular expressions with unicode as needed to validate names in the metamodel (feature(core): Import / Export capabilities between CTO files and metamodel #298)

packages/concerto-core/lib/introspect/stringvalidator.js

Signed-off-by: jeromesimeon <[email protected]>

jeromesimeon requested a review from mttrbrts August 4, 2021 12:45

mttrbrts requested changes Aug 4, 2021

View reviewed changes

packages/concerto-core/lib/introspect/stringvalidator.js Outdated Show resolved Hide resolved

jeromesimeon force-pushed the js-fix-regex-302 branch from cb3a82e to fb880c2 Compare August 4, 2021 15:34

fix(core) Properly handles flags in string regex validators

6d9f073

Signed-off-by: jeromesimeon <[email protected]>

jeromesimeon force-pushed the js-fix-regex-302 branch from fb880c2 to 6d9f073 Compare August 4, 2021 16:28

jeromesimeon requested a review from mttrbrts August 4, 2021 16:28

chore(test) Add tests for string validators using escaped characters

787407e

Signed-off-by: jeromesimeon <[email protected]>

mttrbrts approved these changes Aug 4, 2021

View reviewed changes

jeromesimeon merged commit c4c28e1 into accordproject:master Aug 5, 2021

jeromesimeon deleted the js-fix-regex-302 branch August 5, 2021 13:00