-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root hierarchy + identifiers (v3) #246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromesimeon
force-pushed
the
js-fix-root-hierarchy-v3
branch
3 times, most recently
from
March 28, 2021 15:34
7c39b8b
to
c7cddd3
Compare
@dselman Lots more should be done, notably with testing, but this is in decent shape now and a lot of changes. I'm going to consider this PR ready for review. |
This was referenced Mar 28, 2021
dselman
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LKTM
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
…iers Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
Signed-off-by: Jerome Simeon <[email protected]>
jeromesimeon
force-pushed
the
js-fix-root-hierarchy-v3
branch
from
March 30, 2021 18:54
c7cddd3
to
17cd6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses feedback and some critical issues in Concerto
1.0.0-alpha.2
Changes
Major
Several critical fixes to Concerto
1.0.0-alpha.2
:Participant
Asset
Transaction
andEvent
(Root types have disappeared #228)concerto.*
namespace are now automatically importedtimestamp
is now$timestamp
and only system-generated (Which classes should have timestamps? #242)Tests
Misc
system model
API
Resource
,Identifiable
, etc) now take an (optional)timestamp
parameterClassDeclaration
methods for identifiers are now semantic (is the class is identifiable) rather than syntactic (does the class declaration have anidentified
oridentified by
)CLI
--functional
option to try the new validation API (CLI support for functional API #243)markus
CLI:--ctoFiles --> --model
and--sample --> --input