Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root hierarchy + identifiers (v3) #246

Merged
merged 19 commits into from
Mar 30, 2021
Merged

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Mar 23, 2021

Description

This PR addresses feedback and some critical issues in Concerto 1.0.0-alpha.2

Changes

Major

Several critical fixes to Concerto 1.0.0-alpha.2:

Tests

  • Fixes wrong tests
  • Adds tests for both classic and "functional" validation

Misc

  • Remove some unused code, notably old system model

API

  • model classes (Resource, Identifiable, etc) now take an (optional) timestamp parameter
  • ClassDeclaration methods for identifiers are now semantic (is the class is identifiable) rather than syntactic (does the class declaration have an identified or identified by)

CLI

@jeromesimeon jeromesimeon requested a review from dselman March 23, 2021 20:21
@jeromesimeon jeromesimeon force-pushed the js-fix-root-hierarchy-v3 branch 3 times, most recently from 7c39b8b to c7cddd3 Compare March 28, 2021 15:34
@jeromesimeon
Copy link
Member Author

jeromesimeon commented Mar 28, 2021

@dselman Lots more should be done, notably with testing, but this is in decent shape now and a lot of changes. I'm going to consider this PR ready for review.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LKTM

packages/concerto-core/changelog.txt Outdated Show resolved Hide resolved
packages/concerto-core/lib/factory.js Outdated Show resolved Hide resolved
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon jeromesimeon force-pushed the js-fix-root-hierarchy-v3 branch from c7cddd3 to 17cd6c8 Compare March 30, 2021 18:54
@jeromesimeon jeromesimeon merged commit d92b22c into master Mar 30, 2021
@jeromesimeon jeromesimeon deleted the js-fix-root-hierarchy-v3 branch March 30, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants