Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (root types) : add abstract root types in concerto ns #230

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Feb 9, 2021

Signed-off-by: Dan Selman [email protected]

Issue #228

Adds abstract types to the system concerto namespace:

namespace concerto

abstract concept Concept {}
abstract asset Asset {}
abstract transaction Transaction {}
abstract participant Participant {}
abstract event Event {}

@dselman dselman requested a review from jeromesimeon February 9, 2021 07:47
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Could we add something based on the example in the original issue as a test?

@dselman dselman requested a review from jeromesimeon February 9, 2021 17:10
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dselman dselman merged commit 4572051 into master Feb 9, 2021
@dselman dselman deleted the ds-abstract-root-types branch February 9, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants