Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Remove Ability to Customise the System Model(s) #164

Closed
wants to merge 9 commits into from
Closed

(WIP) Remove Ability to Customise the System Model(s) #164

wants to merge 9 commits into from

Conversation

jeromesimeon
Copy link
Member

Issue #62

Changes

  • Remove ability to customise system models
    • Remove notion of systems table
    • Always uses a fixed built-in system models for Asset Transaction Event and Participant
  • Some changes to criteria allowing relationships (now relationship can be created to any class with an identifier)
  • Numerous fixes to tests, notably since now hyper ledger CTO in tests is no longer added as a systems model.

Flags

  • Very unsure about the general approach to identifiers and to relationships. Needs review
  • What should be the namespace for the system model?
  • What should be the definition for the system model. Should they extend Concept?
  • Some code cleanup/renaming might be nice (notably in testing)

@jeromesimeon
feature(core) Stricter validation for atomic values
b4ef2eb 
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
feature(core) Validation rejects dates that are not in ISO 8601 format
f33cff4 
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
test(validation) More atomic value validation tests
e3b1083 
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
fix(validation) Serializing a not finite Double throws a validation e…
4e0a6cb 
…rror #158

Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
fix(core) Adjustments for Ergo-targeted validation to support new Erg…
625a931 
…o backend and runtime

Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
Fixes to optional validation/serialization
a06aea7 
Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
Fix: move optional handling for Ergo to a more common place so it get…
a118b34 
…s applied to relationships

Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
(WIP) Remove the notion of systems table. System types are always: As…
5297c9d 
…set, Participant, Event, Transaction

Signed-off-by: Jerome Simeon <[email protected]>
@jeromesimeon
feature(core) Remove ability to define systems model, uses a fixed de…
8c5aeb6 
…finition for all core types

Signed-off-by: Jerome Simeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman Awaiting requested review from dselman

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeromesimeon