Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Ergo from Concerto #610

Closed
mttrbrts opened this issue Feb 22, 2023 · 1 comment · Fixed by #637
Closed

Remove references to Ergo from Concerto #610

mttrbrts opened this issue Feb 22, 2023 · 1 comment · Fixed by #637
Assignees

Comments

@mttrbrts
Copy link
Member

mttrbrts commented Feb 22, 2023

With the Ergo language no longer maintained we should clean up all of the code paths that are Ergo-specific in Concerto.

This is expected to be a breaking-change because it will require removing parameters from some public API operations. However, the impact is expected to be very limited, because the only usage of those parameters is within the Ergo engine.

We could consider retaining the ordering of parameters in API operations so as not to force a new major version ahead of time.

Examples of redundant code can be found with the following query:
https://github.com/search?q=repo%3Aaccordproject%2Fconcerto+ergo+language%3ATypeScript+OR+language%3AJavaScript&type=code&l=TypeScript

e.g.

if (this.ergo) {
const theClass = result.$class;
delete result.$class;
result = {
$class: {
$coll: [theClass],
$length: 1
},
$data: result,
};
}

The clean-up should also remove redundant tests, and CLI operations.

@mttrbrts mttrbrts transferred this issue from accordproject/apap Feb 22, 2023
@jonathan-casey jonathan-casey self-assigned this Feb 22, 2023
@jamieshorten
Copy link
Collaborator

Please assign this to me.

jamieshorten added a commit to jamieshorten/concerto that referenced this issue Apr 21, 2023
jamieshorten added a commit to jamieshorten/concerto that referenced this issue Apr 21, 2023
jamieshorten added a commit to jamieshorten/concerto that referenced this issue Apr 24, 2023
Add dummy `ergo` parameter to the constructor of `JSONPopulator` to avoid breaking any consumers.

Signed-off-by: Jamie Shorten <[email protected]>
jamieshorten added a commit to jamieshorten/concerto that referenced this issue Apr 24, 2023
Add `false` for ergo, to prevent errors.

Signed-off-by: Jamie Shorten <[email protected]>
jamieshorten added a commit to jamieshorten/concerto that referenced this issue Apr 24, 2023
Add dummy parameter `ergo` to `JSONGenerator` constructor

Signed-off-by: Jamie Shorten <[email protected]>
mttrbrts pushed a commit that referenced this issue Apr 24, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Ergo Replacement Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants