-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to Ergo from Concerto #610
Comments
Please assign this to me. |
jamieshorten
added a commit
to jamieshorten/concerto
that referenced
this issue
Apr 21, 2023
Signed-off-by: Jamie Shorten <[email protected]>
5 tasks
jamieshorten
added a commit
to jamieshorten/concerto
that referenced
this issue
Apr 21, 2023
Signed-off-by: Jamie Shorten <[email protected]>
jamieshorten
added a commit
to jamieshorten/concerto
that referenced
this issue
Apr 24, 2023
Add dummy `ergo` parameter to the constructor of `JSONPopulator` to avoid breaking any consumers. Signed-off-by: Jamie Shorten <[email protected]>
jamieshorten
added a commit
to jamieshorten/concerto
that referenced
this issue
Apr 24, 2023
Add `false` for ergo, to prevent errors. Signed-off-by: Jamie Shorten <[email protected]>
jamieshorten
added a commit
to jamieshorten/concerto
that referenced
this issue
Apr 24, 2023
Add dummy parameter `ergo` to `JSONGenerator` constructor Signed-off-by: Jamie Shorten <[email protected]>
mttrbrts
pushed a commit
that referenced
this issue
Apr 24, 2023
Signed-off-by: Jamie Shorten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the Ergo language no longer maintained we should clean up all of the code paths that are Ergo-specific in Concerto.
This is expected to be a breaking-change because it will require removing parameters from some public API operations. However, the impact is expected to be very limited, because the only usage of those parameters is within the Ergo engine.
We could consider retaining the ordering of parameters in API operations so as not to force a new major version ahead of time.
Examples of redundant code can be found with the following query:
https://github.com/search?q=repo%3Aaccordproject%2Fconcerto+ergo+language%3ATypeScript+OR+language%3AJavaScript&type=code&l=TypeScript
e.g.
concerto/packages/concerto-core/lib/serializer/jsongenerator.js
Lines 123 to 133 in 2f22485
The clean-up should also remove redundant tests, and CLI operations.
The text was updated successfully, but these errors were encountered: