fix(core) Better error messages for out of range numeric values

Signed-off-by: Jerome Simeon <[email protected]>
accordproject · Feb 1, 2022 · a691df3 · a691df3
1 parent b3a1acb
commit a691df3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/concerto-core/lib/introspect/numbervalidator.js b/packages/concerto-core/lib/introspect/numbervalidator.js
@@ -82,11 +82,11 @@ class NumberValidator extends Validator{
     validate(identifier, value) {
         if(value !== null) {
             if(this.lowerBound !== null && value < this.lowerBound) {
-                this.reportError(identifier, 'Value is outside lower bound ' + value);
+                this.reportError(identifier, `Value ${value} is outside lower bound ${this.lowerBound}`);
             }
 
             if(this.upperBound !== null && value > this.upperBound) {
-                this.reportError(identifier, 'Value is outside upper bound ' + value);
+                this.reportError(identifier, `Value ${value} is outside upper bound ${this.upperBound}`);
             }
         }
     }

diff --git a/packages/concerto-core/test/introspect/numbervalidator.js b/packages/concerto-core/test/introspect/numbervalidator.js
@@ -86,15 +86,15 @@ describe('NumberValidator', () => {
 
             (() => {
                 v.validate('id', -1);
-            }).should.throw(/org.acme.myField: Value is outside lower bound -1/);
+            }).should.throw(/org.acme.myField: Value -1 is outside lower bound 0/);
         });
 
         it('should detect upper bound violation', () => {
             let v = new NumberValidator(mockField, VALID_UPPER_AND_LOWER_BOUND_AST);
 
             (() => {
                 v.validate('id', 101);
-            }).should.throw(/org.acme.myField: Value is outside upper bound 101/);
+            }).should.throw(/org.acme.myField: Value 101 is outside upper bound 100/);
         });
 
         it('should ignore missing upper bound', () => {
@@ -103,7 +103,7 @@ describe('NumberValidator', () => {
 
             (() => {
                 v.validate('id', -1);
-            }).should.throw(/org.acme.myField: Value is outside lower bound -1/);
+            }).should.throw(/org.acme.myField: Value -1 is outside lower bound 0/);
         });
 
         it('should ignore missing lower bound', () => {
@@ -112,7 +112,7 @@ describe('NumberValidator', () => {
 
             (() => {
                 v.validate('id', 101);
-            }).should.throw(/org.acme.myField: Value is outside upper bound 101/);
+            }).should.throw(/org.acme.myField: Value 101 is outside upper bound 100/);
         });
 
         it('should do nothing if no value is given', () => {