Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): Support string length validation #3

Merged
merged 1 commit into from
May 16, 2023

Conversation

ragi-dayananda
Copy link
Contributor

Closes accordproject/concerto#643

Changes

  • Add concepts for string length validator for string property and string scalar property
  • Update test points for the changes.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@ragi-dayananda ragi-dayananda requested a review from a team May 16, 2023 06:54
@mttrbrts mttrbrts enabled auto-merge (squash) May 16, 2023 08:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4988808314

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.03%

Totals Coverage Status
Change from base Build 4935291883: 0.0%
Covered Lines: 83
Relevant Lines: 84

💛 - Coveralls

@mttrbrts mttrbrts merged commit 2ab4abe into accordproject:main May 16, 2023
@dselman
Copy link
Contributor

dselman commented May 16, 2023

Note that because this is still version 1.0.0 of the metamodel any existing code or clients that has been coded against the 1.0.0 version of the metamodel (or validates it...) must ignore these new optional properties.

I think this is ok - but it is somewhat risky, depending on how we roll out these changes across the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support min and max length for a string property in CTO
4 participants