Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): Codegen for Go Target #62

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Conversation

jonathan-casey
Copy link
Member

@jonathan-casey jonathan-casey commented Oct 11, 2023

Description

Add Go code generation for Map Type.

Sample

dictionary1 := make(map[string]string)

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary

@jonathan-casey jonathan-casey requested a review from a team October 11, 2023 15:10
jonathan-casey and others added 2 commits October 11, 2023 16:10
Signed-off-by: Jonathan-Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey jonathan-casey changed the title Jonathan/codegen map golang feat(map): Add Map Type CodeGen for Go Target Oct 11, 2023
@coveralls
Copy link

coveralls commented Oct 11, 2023

Coverage Status

coverage: 98.949% (+0.005%) from 98.944%
when pulling cb72d75 on jonathan/codegen_map_golang
into e3111a0 on main.

@jonathan-casey jonathan-casey changed the title feat(map): Add Map Type CodeGen for Go Target feat(map): Codegen for Go Target Oct 12, 2023
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments.

Please confirm that you can compile the output string.

lib/codegen/fromcto/golang/golangvisitor.js Outdated Show resolved Hide resolved
lib/codegen/fromcto/golang/golangvisitor.js Outdated Show resolved Hide resolved
@jonathan-casey
Copy link
Member Author

@dselman the type is now retrieved from the model file.

@mttrbrts mttrbrts added this to the v3.x milestone Nov 8, 2023
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey jonathan-casey merged commit 07afdc6 into main Nov 8, 2023
11 checks passed
@jonathan-casey jonathan-casey deleted the jonathan/codegen_map_golang branch November 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants