Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map): Codegen for Java Target #58

Merged
merged 23 commits into from
Nov 6, 2023
Merged

feat(map): Codegen for Java Target #58

merged 23 commits into from
Nov 6, 2023

Conversation

jonathan-casey
Copy link
Member

@jonathan-casey jonathan-casey commented Oct 10, 2023 •
edited
Loading

Description

Add Java code generation for Map Type.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@jonathan-casey jonathan-casey force-pushed the jonathan/codegen_map_java branch from f5f9918 to faede00 Compare October 10, 2023 12:51
@jonathan-casey jonathan-casey marked this pull request as ready for review October 10, 2023 16:32
@jonathan-casey jonathan-casey requested a review from a team October 10, 2023 16:32
@jonathan-casey jonathan-casey force-pushed the jonathan/codegen_map_java branch 2 times, most recently from f6eaf4f to ca535bb Compare October 10, 2023 16:40
@coveralls
Copy link

coveralls commented Oct 10, 2023 •
edited
Loading

Coverage Status

coverage: 98.944% (+0.005%) from 98.939%
when pulling 64b1f1f on jonathan/codegen_map_java
into 26a0b79 on main.

@jonathan-casey jonathan-casey force-pushed the jonathan/codegen_map_java branch from ca535bb to cb8b967 Compare October 10, 2023 16:50
ekarademir
ekarademir approved these changes Oct 11, 2023
View reviewed changes
lib/codegen/fromcto/java/javavisitor.js Outdated Show resolved Hide resolved
lib/codegen/fromcto/java/javavisitor.js Show resolved Hide resolved
@mttrbrts
Copy link
Member

Are you able to compile the output source code for your test case with the Java compiler?

@jonathan-casey
Copy link
Member Author

jonathan-casey commented Oct 11, 2023 •
edited
Loading

@mttrbrts yes, thats a prerequisite to merging any of the runtime targets.

@jonathan-casey jonathan-casey changed the title feat(map): Map Type CodeGen for Java Target feat(map): Codegen for Java Target Oct 12, 2023
dselman
dselman requested changes Oct 19, 2023
View reviewed changes
lib/codegen/fromcto/java/javavisitor.js Outdated Show resolved Hide resolved
@jonathan-casey jonathan-casey force-pushed the jonathan/codegen_map_java branch from 1976f5c to 8914d2f Compare November 3, 2023 10:27
jonathan-casey and others added 17 commits November 3, 2023 10:30
@jonathan-casey
feat(map): add map for javavisitor
19919c8 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat(map): update snapshot
d9a482b 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat(map): add test cases
a561e7a 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
remove redundant ternary expression
2fdb635 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat(map): get type from ModelFile
d49ab1c 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
chore(deps): upgrade concerto
f34f96b 
Signed-off-by: Jonathan Casey <[email protected]>
@ragi-dayananda @jonathan-casey
fix(csharp):remove semicolon (;) from map property declaration (#60)
6d25e39 
fix(csharp):remove ; from map property declaration

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
chore: fix package version
0f05e7f 
Signed-off-by: Jonathan Casey <[email protected]>
@github-actions @jonathan-casey
chore(actions): publish v3.16.2 to npm (#61)
99b4e09 
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Jonathan-Casey <[email protected]>
Co-authored-by: Jonathan-Casey <[email protected]>
Co-authored-by: Jonathan-Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat(map): Codegen for GraphQL Target (#66)
36e2e7f 
* feat(map): add graphqlvisitor

Signed-off-by: Jonathan Casey <[email protected]>

* test(map): update snapshot

Signed-off-by: Jonathan Casey <[email protected]>

* test(map): adds graphqlvisitor

Signed-off-by: Jonathan Casey <[email protected]>

* test(map): restores sandbox

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat!(codegen): remove loopback src (#59)
e4630cd 
feat(codegen): remove loopback src

Signed-off-by: Jonathan Casey <[email protected]>
@dependabot @jonathan-casey
chore(deps-dev): bump @babel/traverse from 7.22.11 to 7.23.2 (#67)
673e012 
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.11 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan Casey <[email protected]>
@dselman @jonathan-casey
test(codegen) update HR model to use multiple namespaces (#68)
f97ef0f 
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
feat(map): update snapshot
4147fe1 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
chore(deps): upgrade concerto
541fb78 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
chore(deps): upgrade concerto
5b2fca7 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
test(*): snapshot update
5cf9d21 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey jonathan-casey force-pushed the jonathan/codegen_map_java branch 2 times, most recently from d09af97 to 5cf9d21 Compare November 3, 2023 10:38
@jonathan-casey
fix merge conflict
a01fe38 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
test(*): snapshot update
5b97a34 
Signed-off-by: Jonathan Casey <[email protected]>
dselman
dselman approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-casey jonathan-casey merged commit e3111a0 into main Nov 6, 2023
11 checks passed
@jonathan-casey jonathan-casey deleted the jonathan/codegen_map_java branch November 6, 2023 14:07
@mttrbrts mttrbrts added this to the v3.x milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dselman dselman dselman approved these changes

@ekarademir ekarademir ekarademir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Concerto Roadmap
Status: Done
Milestone
v3.x
Development

Successfully merging this pull request may close these issues.
6 participants
@jonathan-casey @coveralls @mttrbrts @ekarademir @dselman @ragi-dayananda