Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser) : package.json bug #41

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(browser) : package.json bug #41

merged 1 commit into from
Jul 12, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Jul 12, 2023 •
edited
Loading

Closes #40

Fixes browser entry point in package.json to align with webpack config.

See

concerto-codegen/webpack.config.js

Line 28 in e37980b

path: path.join(__dirname, 'umd'),

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman requested a review from a team July 12, 2023 09:55
@coveralls
Copy link

Coverage Status

coverage: 98.942%. remained the same when pulling c378a70 on ds-fix-browser into e37980b on main.

@dselman dselman merged commit 818cb72 into main Jul 12, 2023
@dselman dselman deleted the ds-fix-browser branch July 12, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollup fails to bundle module
3 participants
@dselman @coveralls @mttrbrts