bug(lib): mermaid diagram bug solution #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
More context here: accordproject/concerto#649
Changes
visitRelationship
method fromMermaidVisitor
class was overriding the same method inDiagramVisitor
class, which caused this issue.visitRelationship
fromMermaidVisitor
class towriteRelationshipAggregation
method, which acts as helper method now create the relationship-aggregation line in mermaid diagram code.Flags
MermaidVisitor
class no more hasvisitRelationship
method, not sure if this would break the visitor pattern. Wanted to clarify if this is the correct approach.Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname