Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(lib): mermaid diagram bug solution #39

Conversation

sanketshevkar
Copy link
Member

Closes #38

More context here: accordproject/concerto#649

Changes

  • visitRelationship method from MermaidVisitor class was overriding the same method in DiagramVisitor class, which caused this issue.
  • Changed visitRelationship from MermaidVisitor class to writeRelationshipAggregation method, which acts as helper method now create the relationship-aggregation line in mermaid diagram code.

Flags

  • MermaidVisitor class no more has visitRelationship method, not sure if this would break the visitor pattern. Wanted to clarify if this is the correct approach.

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@coveralls
Copy link

Coverage Status

coverage: 98.942%. remained the same when pulling 4173fad on sanketshevkar:sanketshevkar/i38/mermaid-diagram-code-correction into c1e909f on accordproject:main.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dselman dselman merged commit e37980b into accordproject:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid diagram is incorrect
3 participants