Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript) do not create unions for enums and fix imports #33

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(typescript) do not create unions for enums and fix imports #33

merged 1 commit into from
Jun 6, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Jun 6, 2023 •
edited
Loading

Closes #34

Changes

  • Do not include enums in the generated union types
  • Do not prefix imports of enums with an I.

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman requested review from a team and jonathan-casey June 6, 2023 18:27
@coveralls
Copy link

Coverage Status

coverage: 98.921%. remained the same when pulling 4125fb7 on ds-ts-enum-fix into 8f0cd19 on main.

@dselman dselman merged commit 1200c2c into main Jun 6, 2023
@dselman dselman deleted the ds-ts-enum-fix branch June 6, 2023 18:43
@coveralls
Copy link

Coverage Status

coverage: 98.921%. first build
when pulling 4125fb7 on ds-ts-enum-fix
into 8f0cd19 on main.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 98.921%. first build
when pulling 4125fb7 on ds-ts-enum-fix
into 8f0cd19 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-casey jonathan-casey Awaiting requested review from jonathan-casey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript codegen creates invalid code for models with enums
2 participants
@dselman @coveralls