Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): String length validation for csharp,json generators #19

Merged
merged 4 commits into from
May 23, 2023

Conversation

ragi-dayananda
Copy link
Contributor

@ragi-dayananda ragi-dayananda commented May 22, 2023

Closes

Changes

  • String length validation incorporated to csharp and json schema codegen module

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@ragi-dayananda ragi-dayananda requested a review from a team May 22, 2023 12:57
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to do an npm install to rebuild package-lock.json?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5055871217

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.953%

Totals Coverage Status
Change from base Build 5022427494: 0.007%
Covered Lines: 2192
Relevant Lines: 2200

💛 - Coveralls

@ragi-dayananda ragi-dayananda requested a review from mttrbrts May 23, 2023 10:04
@mttrbrts mttrbrts merged commit 9563f99 into accordproject:main May 23, 2023
@coveralls
Copy link

Coverage Status

coverage: 98.953% (+0.007%) from 98.946%
when pulling 296bb4a on ragi-dayananda:main
into bf5fdbf on accordproject:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants