Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decorator): validation of decorators #145

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Oct 22, 2024

Changes

  • Updates to use latest unstable concerto-core and verifies that we do not have any errors if decorators use undeclared types

Flags

  • Typescript union test was modified to not use IDecorator as that type is now declared twice (once in concerto.decorator and once in meta model).

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@coveralls
Copy link

coveralls commented Oct 23, 2024

Coverage Status

coverage: 98.794%. remained the same
when pulling 6695b5e on ds-decorator-validation
into 9aa6167 on main.

@dselman dselman requested a review from ekarademir October 23, 2024 16:41
@ekarademir ekarademir merged commit a95db19 into main Oct 24, 2024
11 checks passed
@ekarademir ekarademir deleted the ds-decorator-validation branch October 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants