feat: added exception for reserved keywords #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kailash Kejriwal <[email protected]>
Signed-off-by: Kailash Kejriwal <[email protected]>
|
This PR will add the feature to throw an exception if reserved keywords are used in a JSON schema. |
sanketshevkar
requested changes
Mar 8, 2024
| @@ -614,7 +638,10 @@ class JsonSchemaVisitor { | |||
| }; | |||
|
|
|||
| // Handle reserved properties. | |||
| if (['$identifier', '$class', '$timestamp'].includes(propertyName)) { | |||
| if (privateReservedProperties.includes(propertyName)) { | |||
There was a problem hiding this comment.
Thanks for your contribution @kailash360 :). We already have a utility function for the check.
Please use this.
There was a problem hiding this comment.
Done, I have replaced them with the ModelUtil methods.
|
@stefanblaginov @mttrbrts can you please review this PR? |
Signed-off-by: Kailash Kejriwal <[email protected]>
jonathan-casey
requested changes
Mar 11, 2024
Co-authored-by: jonathan-casey <[email protected]> Signed-off-by: Dan Selman <[email protected]>
Co-authored-by: jonathan-casey <[email protected]> Signed-off-by: Dan Selman <[email protected]>
dselman
approved these changes
May 7, 2024
mttrbrts
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
It adds the feature to throw an exception if the JSON schema contains any reserved keyword. These reserved keywords are categorized into
private- which is used internally by Concerto, andassignable- which is used in serialization. Errors are thrown only if aprivatekeyword is encountered.Changes
Flags
N/A
Screenshots or Video
N/A
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname