Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Make Clause Template background color lighter #322

Closed
Michael-Grover opened this issue Mar 4, 2020 · 10 comments · Fixed by #323 or #325
Closed

Make Clause Template background color lighter #322

Michael-Grover opened this issue Mar 4, 2020 · 10 comments · Fixed by #323 or #325
Assignees
Labels
A11Y 🔓 Accessibility related Difficulty: Starter Good First Issue (Taken) Type: Enhancement ✨ Improvement to process or efficiency

Comments

@Michael-Grover
Copy link
Collaborator

Change clause template background color from #ECF0FA to #F9FBFF to increase contrast. Increased contrast will improve accessibility and allow more flexibility for how we design future improvements like this: #314

Current
image

Proposed
image

@jolanglinais jolanglinais added A11Y 🔓 Accessibility related Difficulty: Starter Good First Issue :octocat: Good for newcomers Type: Enhancement ✨ Improvement to process or efficiency labels Mar 4, 2020
@sachdeva-shrey
Copy link
Contributor

Can I work on this one? @Michael-Grover

@Michael-Grover
Copy link
Collaborator Author

Michael-Grover commented Mar 5, 2020 via email

@elit-altum
Copy link
Contributor

elit-altum commented Mar 5, 2020

@shrey-sachdeva2000 @irmerk This is actually a continuation of my PR here at #318 (comment) so I had already made the changes along with the colors and margins. Could I please continue with it and make a PR ?

Thank you!

@sachdeva-shrey
Copy link
Contributor

@shrey-sachdeva2000 @irmerk This is actually a continuation of my PR here at #318 (comment) so I had already made the changes along with the colors and margins. Could I please continue with it and make a PR ?

Thank you!

I didn't mean to step on any toes @elit-altum. Was just making the PR when you commented. I don't mind taking it back if you'd like!

@elit-altum
Copy link
Contributor

@shrey-sachdeva2000 @irmerk This is actually a continuation of my PR here at #318 (comment) so I had already made the changes along with the colors and margins. Could I please continue with it and make a PR ?
Thank you!

I didn't mean to step on any toes @elit-altum. Was just making the PR when you commented. I don't mind taking it back if you'd like!

I don't know now. I guess some formatting changes were also to be made which were discussed in the previous PR. I think we should let @irmerk and @Michael-Grover decide

@elit-altum
Copy link
Contributor

@shrey-sachdeva2000 I will move on to handle the spacing and margins instead.

@jolanglinais
Copy link
Member

@elit-altum sorry! I didn't fully read through the issue again before merging #323

@elit-altum
Copy link
Contributor

No problem @irmerk!
I'll make a separate PR for spacing and borders as suggested by @Michael-Grover

@jolanglinais
Copy link
Member

Whoopsie, reopening because the Clause Header that shows on hover needs it's gradient color updated to be in line with this new background color.

@jolanglinais jolanglinais reopened this Mar 6, 2020
@elit-altum
Copy link
Contributor

@irmerk Can I handle this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A11Y 🔓 Accessibility related Difficulty: Starter Good First Issue (Taken) Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
4 participants