-
Notifications
You must be signed in to change notification settings - Fork 45
Make Clause Template background color lighter #322
Comments
Can I work on this one? @Michael-Grover |
Sure
…On Thu, Mar 5, 2020, 12:17 AM Shrey Sachdeva ***@***.***> wrote:
Can I work on this one? @Michael-Grover
<https://github.com/Michael-Grover>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#322?email_source=notifications&email_token=AJVQXQJV6HJE4EIMQNCK6RLRF4YVBA5CNFSM4LBYX55KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN3X35Q#issuecomment-595033590>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJVQXQJHA4LEMNOBZLIH75TRF4YVBANCNFSM4LBYX55A>
.
|
@shrey-sachdeva2000 @irmerk This is actually a continuation of my PR here at #318 (comment) so I had already made the changes along with the colors and margins. Could I please continue with it and make a PR ? Thank you! |
I didn't mean to step on any toes @elit-altum. Was just making the PR when you commented. I don't mind taking it back if you'd like! |
I don't know now. I guess some formatting changes were also to be made which were discussed in the previous PR. I think we should let @irmerk and @Michael-Grover decide |
@shrey-sachdeva2000 I will move on to handle the spacing and margins instead. |
@elit-altum sorry! I didn't fully read through the issue again before merging #323 |
No problem @irmerk! |
Whoopsie, reopening because the Clause Header that shows on hover needs it's gradient color updated to be in line with this new background color. |
@irmerk Can I handle this? |
Change clause template background color from #ECF0FA to #F9FBFF to increase contrast. Increased contrast will improve accessibility and allow more flexibility for how we design future improvements like this: #314
Current
Proposed
The text was updated successfully, but these errors were encountered: