Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow play stats for artist #686

Merged
merged 8 commits into from
Jan 15, 2022
Merged

Allow play stats for artist #686

merged 8 commits into from
Jan 15, 2022

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Dec 30, 2021

Allow the user to see their play stats per artist.

The layout of the stats page stays the same, just with filtered plays/tracks. Plays are currently only filtered based on the track_artists.

To access this page, I added a stats icon to the ArtistActions. I'm unsure if this needs to be shown in both the card and on the artist page, both left it like this for now.

Some screenshots showing all visual changes:
Screenshot 2021-12-30 at 10 15 24
Screenshot 2021-12-30 at 10 16 07
Screenshot 2021-12-30 at 10 16 14
Screenshot 2021-12-30 at 10 24 57

@robbevp robbevp added the enhancement New feature or request label Dec 30, 2021
@robbevp robbevp requested a review from chvp December 30, 2021 09:26
@robbevp robbevp self-assigned this Dec 30, 2021
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not show this on the card. It's not that much of a primary action, IMO.

@robbevp
Copy link
Member Author

robbevp commented Jan 4, 2022

I've updated this to only show the stats button on the artist's page

@robbevp robbevp requested a review from chvp January 4, 2022 13:45
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following warning in the console:

[Vue warn]: Invalid prop: type check failed for prop "extended". Expected Boolean, got String with value "true".

found in

---> <ArtistActions> at src/components/ArtistActions.vue
       <Artist> at src/views/artists/Artist.vue
         <VMain>
           <App> at src/views/App.vue
             <VApp>
               <Main> at src/Main.vue
                 <Root>

Also, this is for a separate issue/PR, but we need better content if there are no plays for the selected period. I selected an artist I know I listen a lot to, but haven't listened to in the past week, and thought this was broken until I figured out I had to change the period.

src/locales/nl.json Outdated Show resolved Hide resolved
Co-authored-by: Charlotte Van Petegem <[email protected]>
@robbevp
Copy link
Member Author

robbevp commented Jan 15, 2022

I get the following warning in the console:

[Vue warn]: Invalid prop: type check failed for prop "extended". Expected Boolean, got String with value "true".

found in

---> <ArtistActions> at src/components/ArtistActions.vue
       <Artist> at src/views/artists/Artist.vue
         <VMain>
           <App> at src/views/App.vue
             <VApp>
               <Main> at src/Main.vue
                 <Root>

Also, this is for a separate issue/PR, but we need better content if there are no plays for the selected period. I selected an artist I know I listen a lot to, but haven't listened to in the past week, and thought this was broken until I figured out I had to change the period.

Fixed this warning (and create an issue to track the "empty" state of the stats page

@chvp chvp merged commit 86eb6a1 into main Jan 15, 2022
@chvp chvp deleted the enhc/allow-play-stats-for-artist branch January 15, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants