-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow play stats for artist #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not show this on the card. It's not that much of a primary action, IMO.
I've updated this to only show the stats button on the artist's page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the following warning in the console:
[Vue warn]: Invalid prop: type check failed for prop "extended". Expected Boolean, got String with value "true".
found in
---> <ArtistActions> at src/components/ArtistActions.vue
<Artist> at src/views/artists/Artist.vue
<VMain>
<App> at src/views/App.vue
<VApp>
<Main> at src/Main.vue
<Root>
Also, this is for a separate issue/PR, but we need better content if there are no plays for the selected period. I selected an artist I know I listen a lot to, but haven't listened to in the past week, and thought this was broken until I figured out I had to change the period.
Co-authored-by: Charlotte Van Petegem <[email protected]>
Fixed this warning (and create an issue to track the "empty" state of the stats page |
Allow the user to see their play stats per artist.
The layout of the stats page stays the same, just with filtered plays/tracks. Plays are currently only filtered based on the track_artists.
To access this page, I added a stats icon to the
ArtistActions
. I'm unsure if this needs to be shown in both the card and on the artist page, both left it like this for now.Some screenshots showing all visual changes: