Move recalculation of content lengths to background job #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbevp
commented
Oct 27, 2023
robbevp
force-pushed
the
fix/background-job-recalculate-content-lengths
branch
from
b62f4f6
to
86f1974
Compare
chvp
reviewed
Oct 28, 2023
|
Not sure how that got there - I'd rather fix this while we're at it. |
chvp
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
I moved the iteration over all audio files to its own job. We'd want to run
ContentLength.destroy_allASAP after boot, since a version mismatch could result in issues for users. If this turns out to still be a bottleneck, we can also switch toContentLength.delete_all(as we don't have any lifecycle callbacks for content lengths, or need to delete associated models when destroying).