Fix error if tags contain null byte(s) #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No test, because I couldn't figure out how to create a file with such tags. I did test locally that the problem files I had scanned without issue.
chvp
force-pushed
the
fix/null-byte-tags
branch
from
6618f2f to
7ecb199
Compare
robbevp
reviewed
Sep 2, 2023
Co-authored-by: Robbe Van Petegem <[email protected]>
|
I don't think upstreaming is the right fix. As mentioned in the comment, some programs use the null bytes to separate multiple values in a tag. Other consumers of WahWah might want to go through the effort of using that information. |
robbevp
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test, because I couldn't figure out how to create a file with such tags. I did test locally that the problem files I had scanned without issue.