Allow database_host to be specified through ENV var #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
requested changes
Apr 3, 2022
chvp
changed the title
robbevp
force-pushed
the
chore/allow-dtabase-host-through-env
branch
from
3382d42
to
1580b85
Compare
chvp
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my local development setup I've been switching to a postgres instance per project, which runs in
tmp/postgres.To easily use this database, I'd like to set the database_host through an ENV variable. (I could also do this with a database_url, but this requires the variable to be URI encoded, where the host can be a regular path. It's just a bit easier to set
/path/to/accentor/api/tmp/postgresrather thanpostgres://%2fpath%2fto%2faccentor%2fapi%2ftmp%2fpostgres/accentor_development)Since I added the fallback to localhost, this should not cause any difference to other users. Due to the way Rails' connection preference works, this also should not cause a difference for people who currently use the DATABASE_URL ENV var.