Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ruby 3.1 #283

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Update to ruby 3.1 #283

merged 2 commits into from
Jan 22, 2022

Conversation

chvp
Copy link
Member

@chvp chvp commented Jan 22, 2022

No description provided.

@chvp chvp added the chore Repository or build maintenance label Jan 22, 2022
@chvp chvp requested a review from robbevp January 22, 2022 08:16
robbevp
robbevp approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: did you do some manual tests as well? Rails 7 had some issues with ruby 3.1 (which were fixed in Rails 7.0.1). Not sure if the same was the case for Rails 6.1

@chvp
Copy link
Member Author

chvp commented Jan 22, 2022

I did, yes.

@chvp chvp merged commit 3461fde into main Jan 22, 2022
@chvp chvp deleted the chore/ruby-3.1 branch January 22, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbevp robbevp robbevp approved these changes

Assignees
No one assigned
Labels
chore Repository or build maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chvp @robbevp