Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version inside application and add to headers #251

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Sep 8, 2021

This PR does two things:

  • Adds the application version in an initializer, so it can be used inside the application
  • Adds an extra header to the default headers, with the version. (Which will be helpful when debugging in production or if we ever need to handle breaking changes in web/android)

A test didn't really seem relevant, but we can always test that the header is present in a random request

@robbevp robbevp added the chore Repository or build maintenance label Sep 8, 2021
@robbevp robbevp self-assigned this Sep 8, 2021
@robbevp robbevp requested a review from chvp September 8, 2021 19:18
@chvp chvp merged commit b73dad4 into main Sep 11, 2021
@chvp chvp deleted the chore/set-version-of-api-inside-application branch September 11, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository or build maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants