Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add composer from track's metadata #235

Merged
merged 1 commit into from
Jul 31, 2021

Conversation

robbevp
Copy link
Member

@robbevp robbevp commented Jul 31, 2021

This PR changes the way a track's artists are set from the file's metadata during a rescan. Previously, we would not set a composer if the content of the composer field was equal to the content of the artist field. After this change, we always set the composer if the tag is present.

There are two reasons for this change:

  1. The behaviour of the rescan becomes easier to comprehent. If a tag is present in the file, it will show up. The current behaviour can cause situations that are confusing to a user who is not familiar with the code. (For example, when some tracks on an album have the same composer and artists and others don't; or when some tracks have a misspelling of the composer/artist's name).
  2. This sort of "fixes" should be handled while editing. The review comments, that are added by default to every new track, make it easy to have a backlog of items to go through. If a user don't want this duplication, they can remove it, if they want it, they can leave it.

There weren't any tests relevant to this behaviour. I haven't added/updated any tests, since we already had a test for adding a composer to the track.

@robbevp robbevp added the enhancement New feature or request label Jul 31, 2021
@robbevp robbevp requested a review from chvp July 31, 2021 14:41
@robbevp robbevp self-assigned this Jul 31, 2021
@chvp chvp merged commit 73fbcc3 into main Jul 31, 2021
@chvp chvp deleted the enhc/always-set-composer-from-metadata branch July 31, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants