Always add composer from track's metadata #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way a track's artists are set from the file's metadata during a rescan. Previously, we would not set a composer if the content of the composer field was equal to the content of the artist field. After this change, we always set the composer if the tag is present.
There are two reasons for this change:
There weren't any tests relevant to this behaviour. I haven't added/updated any tests, since we already had a test for adding a composer to the track.