Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutlass update #242

Merged
merged 11 commits into from
Jun 25, 2024
Merged

cutlass update #242

merged 11 commits into from
Jun 25, 2024

Conversation

Shreya-gaur
Copy link

No description provided.

@Shreya-gaur Shreya-gaur changed the base branch from release to dev July 17, 2023 15:59
@Shreya-gaur Shreya-gaur requested review from tgrogers and barnes88 July 17, 2023 17:20
@Shreya-gaur Shreya-gaur requested review from JRPan and removed request for barnes88 August 14, 2023 17:15
Copy link
Collaborator

@JRPan JRPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JRPan JRPan closed this Jun 22, 2024
@JRPan JRPan reopened this Jun 22, 2024
@JRPan JRPan closed this Jun 22, 2024
@JRPan JRPan reopened this Jun 22, 2024
@JRPan JRPan added this pull request to the merge queue Jun 24, 2024
Merged via the queue into accel-sim:dev with commit e4e82ef Jun 25, 2024
8 of 13 checks passed
@macto94
Copy link

macto94 commented Jul 4, 2024

when I run ./util/tracer_nvbit/run_hw_trace.py -B cutlass_5_trace -D 0
it says FileNotFoundError: [Errno 2] No such file or directory: '/root/accel-sim-framework/gpu-app-collection/src/..//bin/11.4/release/cutlass_profiler'

it seems that cutlass_profiler is not linked properly.
maybe, should I change 'cutlass_profiler' to 'cutlass_perf_test_k1' in "util/job_launching/apps/define-all-apps.yml" ?
or change 'gpu-app-collection/src/Makefile' to include 'make cutlass_profiler -j12'?

@JRPan
Copy link
Collaborator

JRPan commented Jul 4, 2024

Did you pull latest gpu-app-collection?
Cutlass is included in this commit accel-sim/gpu-app-collection#18

@macto94
Copy link

macto94 commented Jul 5, 2024

@JRPan Yes, I pull latest dev branch. (both accel-sim and gpu-app-collection.)

@JRPan
Copy link
Collaborator

JRPan commented Jul 5, 2024

@Shreya-gaur

@macto94
Copy link

macto94 commented Jul 5, 2024

Temporarily, I modified the cutlass part of the "gpu-app-collection/src/Makefile" as follows, but it needs to be verified.

cutlass:
        mkdir -p $(BINDIR)/$(BINSUBDIR)/
        echo $(BINDIR)
        git submodule init && git submodule update
        #$(SETENV) mkdir -p cuda/cutlass-bench/build && cd cuda/cutlass-bench/build && cmake .. -DUSE_GPGPUSIM=1 -DCUTLASS_NVCC_ARCHS=70 && make cutlass_profiler -j12
        $(SETENV) mkdir -p cuda/cutlass-bench/build && cd cuda/cutlass-bench/build && cmake .. -DUSE_GPGPUSIM=1 -DCUTLASS_NVCC_ARCHS=80 && make cutlass_profiler -j12
#       cd cuda/cutlass-bench/build/tools/profiler && ln -s -f ../../../../binary.sh . && ./binary.sh
        echo $(BINDIR)
        cp cuda/cutlass-bench/build/tools/profiler/cutlass_profiler $(BINDIR)/$(BINSUBDIR)/

# I was unsure of the role of k2 and k3, so I removed them for now.
#        cp $(BINDIR)/$(BINSUBDIR)/cutlass_perf_test_k1 $(BINDIR)/$(BINSUBDIR)/cutlass_perf_test_k2
#        cp $(BINDIR)/$(BINSUBDIR)/cutlass_perf_test_k1 $(BINDIR)/$(BINSUBDIR)/cutlass_perf_test_k3

but, when I try to simulate the traces of wmma-gemm with generated A100 config, "Segmentation fault" is raised.
I only change the args of "define-all-apps.yml"

cutlass_5_trace:
    exec_dir: "$GPUAPPS_ROOT/bin/$CUDA_VERSION/release/"
    data_dirs: "$GPUAPPS_ROOT/data_dirs/"
    execs:
        - cutlass_profiler:
            - args: --seed=2020 --dist=0 --operation=gemm --m=512 --n=512 --k=512 --accum=f32 --stages=4 --op_class=tensorop --iterations=1 --provider=cutlass
              accel-sim-mem: 3G

@JRPan
Copy link
Collaborator

JRPan commented Jul 6, 2024

Thanks I'll check that.

@JRPan JRPan mentioned this pull request Jul 6, 2024
JRPan added a commit to JRPan/accel-sim-framework that referenced this pull request Sep 3, 2024
* cutlass: Added cutlass 3.0 to gpu-app-collection

This commit contains the changes in the make file and the
define-app-apps file.

* Commit changes to cutlass app

* Changes for cutlass in define-all-apps

* Changes to define-power.yml for cutlass 3

* Comment change of cutlass

---------

Co-authored-by: JRPan <[email protected]>
Co-authored-by: Tim Rogers <[email protected]>
Co-authored-by: WilliamMTK <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants