Skip to content

Commit

Permalink
Adding aria-label for discover data grid select document checkbox (el…
Browse files Browse the repository at this point in the history
  • Loading branch information
bhavyarm authored and Esteban Beltran committed May 4, 2022
1 parent 7caa070 commit ed7c949
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { euiLightVars as themeLight, euiDarkVars as themeDark } from '@kbn/ui-theme';
import { i18n } from '@kbn/i18n';
import { DiscoverGridContext } from './discover_grid_context';
import { ElasticSearchHit } from '../../types';

Expand All @@ -36,6 +37,11 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
const id = useMemo(() => getDocId(doc), [doc]);
const checked = useMemo(() => selectedDocs.includes(id), [selectedDocs, id]);

const toggleDocumentSelectionLabel = i18n.translate('discover.grid.selectDoc', {
defaultMessage: `Select document '{rowNumber}'`,
values: { rowNumber: rowIndex + 1 },
});

useEffect(() => {
if (expanded && doc && expanded._id === doc._id) {
setCellProps({
Expand All @@ -51,7 +57,7 @@ export const SelectButton = ({ rowIndex, setCellProps }: EuiDataGridCellValueEle
return (
<EuiCheckbox
id={id}
label=""
aria-label={toggleDocumentSelectionLabel}
checked={checked}
data-test-subj={`dscGridSelectDoc-${id}`}
onChange={() => {
Expand Down

0 comments on commit ed7c949

Please sign in to comment.