Skip to content

Commit

Permalink
SOme clarification comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
judgej committed Dec 19, 2018
1 parent ab4ce39 commit 2160b5c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
"name": "Adrian Macneil",
"email": "[email protected]"
},
{
"name": "Jason Judge",
"email": "[email protected]"
},
{
"name": "Omnipay Contributors",
"homepage": "https://github.com/thephpleague/omnipay-sagepay/contributors"
Expand Down
7 changes: 5 additions & 2 deletions src/Message/Form/CompleteAuthorizeRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function getTxType()
public function getData()
{
// The application has the option of passing the query parameter
// in, perhaps using its own middleware, or allowing Omnipay t0
// in, perhaps using its own middleware, or allowing Omnipay to
// provide it.

$crypt = $this->getCrypt() ?: $this->httpRequest->query->get('crypt');
Expand All @@ -45,7 +45,7 @@ public function getData()
}

// Remove the leading '@' and decrypt the remainder into a query string.
// And E_WARNING error will be issued if the crypt parameter data is not
// An InvalidResponseException is thrown if the crypt parameter data is not
// a hexadecimal string.

$hexString = substr($crypt, 1);
Expand All @@ -64,6 +64,9 @@ public function getData()

parse_str($queryString, $data);

// The result will be ASCII data only, being a very restricted set of
// IDs and flags, so can be treated as UTF-8 without any conversion.

return($data);
}

Expand Down

0 comments on commit 2160b5c

Please sign in to comment.