Fix integration TestSingleBinaryWithMemberlistScaling flaking. (corte…

…xproject#4361) This appears to be highlighting an issue - raised as cortexproject#4360. This change just stops the test flaking until it can be fixed. Signed-off-by: Steve Simpson <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
ac1214 · Jan 14, 2022 · d5dc01c · d5dc01c
1 parent 65e3e5d
commit d5dc01c
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/integration/integration_memberlist_single_binary_test.go b/integration/integration_memberlist_single_binary_test.go
@@ -197,6 +197,13 @@ func TestSingleBinaryWithMemberlistScaling(t *testing.T) {
 		c := instances[i]
 		instances = instances[:i]
 		stop.Go(func() error { return s.Stop(c) })
+
+		// TODO(#4360): Remove this when issue is resolved.
+		//   Wait until memberlist for all nodes has recognised the instance left.
+		//   This means that we will not gossip tombstones to leaving nodes.
+		for _, c := range instances {
+			require.NoError(t, c.WaitSumMetrics(e2e.Equals(float64(len(instances))), "memberlist_client_cluster_members_count"))
+		}
 	}
 	require.NoError(t, stop.Wait())