-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILogger factory #809
Merged
Merged
ILogger factory #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeedFileJoining needed to be changed to a bool
Add LastUpdatedBefore to the OrderList response, so it can be used as https://www.youtube.com/watch?v=aeSAo5a6ClQ
Can you solve the Conflict here |
i have updated the merge conflicts, if you are ok with the principle, i can update the rest of the services to have the logger passed through to them, this should be done before this is merged |
Yes it's ok you can do it |
abuzuhri
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just an initial exploration to adding an ILogger to the library, to improve what we can see from logging libraries etc, to make it less of a black box.
I have only done one service for now, but if this gets approval then i can add it to the other services