respect MaxLogFileSize setting even when ELPP_NO_DEFAULT_LOG_FILE is set #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this PR? |
|
Hi @MonsieurNicolas Sorry for the delay and thanks for this PR. |
abumq
added a commit
that referenced
this pull request
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like defining
ELPP_NO_DEFAULT_LOG_FILEdisables features such as MaxLogFileSize even thoughELPP_NO_DEFAULT_LOG_FILEis supposed to only impact the initial state (as per documentation).While this fix changes the behavior, it should not really impact anybody:
it is safe to assume that somebody setting MaxLogFileSize does it when logging to a file.
This is a
I have
CHANGELOG.mdREADME.md