Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remove-ember-data-is-new-serializer-api command #96

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

fivetanley
Copy link
Collaborator

This adds a handy command for removing all the isNewSerializerAPI
properties in serializers after you've finished upgrading.

@@ -82,12 +82,21 @@ program
});

program
.command('replace-needs-with-injection [path]')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetanley it looks like the description here is incorrect? :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not the description but the command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u caught me copying
and pasting
trying to catch me hackin'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍝

@abuiles
Copy link
Owner

abuiles commented Apr 21, 2016

@fivetanley thanks! Looks good, can you fix the 🍝 issue and then I'll merge and release :)

@abuiles abuiles closed this Apr 21, 2016
This adds a handy command for removing all the `isNewSerializerAPI`
properties in serializers after you've finished upgrading.
@abuiles abuiles reopened this Apr 21, 2016
@abuiles
Copy link
Owner

abuiles commented Apr 21, 2016

Sorry, closed by mistake

@fivetanley
Copy link
Collaborator Author

cool, think i got it!

@abuiles abuiles merged commit e61e5d7 into abuiles:master Apr 21, 2016
@abuiles
Copy link
Owner

abuiles commented Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants