fix: Allow YAML files to have no extension #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file extension wasn't used previously to determine if a file was yaml. So the addition of JSON and thus checking of extensions introduced a scenario where yaml files without extension resulted in an error. This change allows resets the default behavior that a file with no extension is assumed to be yaml. Added integration tests to test all three variants
abtreece
added a commit
that referenced
this pull request
Sep 29, 2021
The file extension wasn't used previously to determine if a file was yaml. So the addition of JSON and thus checking of extensions introduced a scenario where yaml files without extension resulted in an error. This change allows resets the default behavior that a file with no extension is assumed to be yaml. Added integration tests to test all three variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file extension wasn't used previously to determine if a file was yaml.
So the addition of JSON and thus checking of extensions introduced a
scenario where yaml files without extension resulted in an error. This
change allows resets the default behavior that a file with no extension
is assumed to be yaml.
Added integration tests to test all three variants