MG-2026 - Fix JSON page response key from groups to channels
#2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffMboya
changed the title
groups to channels
dborovcanin
requested changes
Jun 20, 2024
internal/groups/api/responses.go
Outdated
| @@ -82,7 +82,7 @@ func (res createGroupRes) Empty() bool { | |||
|
|
|||
| type groupPageRes struct { | |||
| pageRes | |||
| Groups []viewGroupRes `json:"groups"` | |||
| Groups []viewGroupRes `json:"channels"` | |||
There was a problem hiding this comment.
Why do we use channel terminology for groups? I.e. no all groups are channels.
dborovcanin
force-pushed
the
MG-2026
branch
2 times, most recently
from
3f0c128 to
8185f20
Compare
dborovcanin
approved these changes
Jun 24, 2024
dborovcanin
requested changes
Jun 24, 2024
dborovcanin
force-pushed
the
MG-2026
branch
2 times, most recently
from
f2c78aa to
6c42c46
Compare
dborovcanin
requested changes
Jun 26, 2024
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
dborovcanin
approved these changes
Jun 26, 2024
andychao217
pushed a commit
to andychao217/magistrala
that referenced
this pull request
Sep 23, 2024
MG-2142 - Consume Things connect/disconnect event in Bootstrap (absmach#2192) NOISSUE - add CreatedAt and UpdatedAt fields for mgclients.Client (absmach#2306) NOISSUE - Fix failed log message (absmach#2307) MF-2299 - Update influxdb2 volumes path (absmach#2300) NOISSUE - Remove redundant relation check (absmach#2197) NOISSUE - Add domain events for Auth service (absmach#2313) NOISSUE - Update CI tools (absmach#2314) MG-888 - Update consumers SDK tests (absmach#2271) MG-888 - Add bootstrap SDK tests (absmach#2261) MG-2026 - Fix JSON page response key from groups to channels (absmach#2298) MG-1965 - Process Event Logs (absmach#2057) MG-1529 - User Removal (absmach#2122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor
What does this do?
This PR fixes the JSON Page response key from
groupstochannelsfor the following endpoints:GET /groups/{groupID}/channelsGET /channelsGET /users/{userID}/channelsWhich issue(s) does this PR fix/relate to?
groupstochannels#2026Have you included tests for your changes?
Manually tested endpoints
Did you document any new/modified feature?
No
Notes