Workaround for values defined as list of atoms (#1041)

absinthe-graphql · Feb 5, 2021 · 19f1e8d · 19f1e8d
1 parent daa79c0
commit 19f1e8d
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/lib/absinthe/schema/notation/sdl_render.ex b/lib/absinthe/schema/notation/sdl_render.ex
@@ -192,7 +192,7 @@ defmodule Absinthe.Schema.Notation.SDL.Render do
         string(enum_type.name),
         directives(enum_type.directives, type_definitions)
       ]),
-      render_list(enum_type.values, type_definitions)
+      render_list(List.flatten(enum_type.values), type_definitions)
     )
     |> description(enum_type.description)
   end
@@ -380,7 +380,22 @@ defmodule Absinthe.Schema.Notation.SDL.Render do
 
   # Render Helpers
 
-  defp render_list(items, type_definitions, seperator \\ line()) do
+  defp render_list(items, type_definitions, seperator \\ line())
+
+  # Workaround for `values` macro which temporarily defines
+  # values as raw atoms to support dynamic schemas
+  defp render_list([first | _] = items, type_definitions, seperator) when is_atom(first) do
+    items
+    |> Enum.map(
+      &%Blueprint.Schema.EnumValueDefinition{
+        value: &1,
+        name: String.upcase(to_string(&1))
+      }
+    )
+    |> render_list(type_definitions, seperator)
+  end
+
+  defp render_list(items, type_definitions, seperator) do
     items = Enum.reject(items, &(&1.module in @skip_modules))
 
     splitter =

diff --git a/test/absinthe/schema/sdl_render_test.exs b/test/absinthe/schema/sdl_render_test.exs
@@ -208,10 +208,13 @@ defmodule Absinthe.Schema.SdlRenderTest do
       value :picking
     end
 
+    enum :status, values: [:one, :two, :three]
+
     object :order do
       field :id, :id
       field :name, :string
       field :status, :order_status
+      field :other_status, :status
       import_fields :imported_fields
     end
 
@@ -255,6 +258,12 @@ defmodule Absinthe.Schema.SdlRenderTest do
 
              union SearchResult = Order | Category
 
+             enum Status {
+               ONE
+               TWO
+               THREE
+             }
+
              enum OrderStatus {
                DELIVERED
                PROCESSING
@@ -266,6 +275,7 @@ defmodule Absinthe.Schema.SdlRenderTest do
                id: ID
                name: String
                status: OrderStatus
+               otherStatus: Status
              }
              """
   end