Make lexer discard comments entirely #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to confirm, |
|
It's hard to look at errors on Travis, but this is the line that's failing:
https://travis-ci.com/github/abs-lang/abs/jobs/368603860#L526
That definitely works on master :) you also see a lot of other errors as we
test for some errors and keep displaying the output even if the goal of the
test is to actually produce an error.
If you wanna see what exactly failed on Travis look for the keyword "FAIL".
Sorry, I know it's a bit painful :)
…On Wed, Aug 5, 2020, 4:47 PM Adrian Ho ***@***.***> wrote:
Just to confirm, pretty much all the errors that appear for my PR in
Travis CI are also appearing when I run go test on the current master
branch. Is that to be expected?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#394 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQFZESV3DQYJZFU3MLWGLR7FIFNANCNFSM4PVLVPCQ>
.
|
gromgit
force-pushed
the
lexer_dump_comments
branch
from
34d6705 to
17f0029
Compare
|
Huh, looks like my copy of the Anyway, I've fixed the test case. Turned out I misinterpreted how the test case worked. |
odino
reviewed
Aug 5, 2020
Alternate solution to abs-lang#388 (previous solution at abs-lang#393). This one skips over comments entirely, so no comment tokens are passed to callers.
gromgit
force-pushed
the
lexer_dump_comments
branch
from
17f0029 to
69705c8
Compare
odino
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate solution to #388 (previous solution at #393). This one causes the lexer to skip over comments entirely, so no comment tokens are passed upwards that need to be dealt with.