Check for newer release on GitHub #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odino
requested changes
Aug 5, 2020
There was a problem hiding this comment.
I am generally wary of using external dependencies, so I'd try to avoid it if possible. We can rely on the fact that ABS' latest version is published here: we could then do a GET to that URL, compare the string we receive to the current version and prompt for an update there. Would you be able to make these changes?
Done. |
odino
reviewed
Aug 5, 2020
Added a command-line flag (--check-update) for scripted use, and prompts in the welcome message in the REPL. Uses https://github.com/tcnksm/go-latest to do the heavy lifting. Closes abs-lang#334.
|
Yes, sorry for not clarifying. I think the freq check should just be there
when you start the repl.
Btw a phase 2 of this feature could be to auto-update the binary when you
run "abs upgrade" or similar. If you wanna do something in that direction
I'd be more than happy to let you experiment :)
…On Wed, Aug 5, 2020, 12:46 PM Adrian Ho ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In repl/repl.go
<#392 (comment)>:
> @@ -228,6 +228,9 @@ func BeginRepl(args []string, version string) {
panic(err)
}
fmt.Printf("Hello %s, welcome to the ABS (%s) programming language!\n", user.Username, version)
+ if newver, update := util.UpdateAvailable(version); update {
Yeah, I can do a 10%-frequency check, but since there's also a
--check-update command-line flag (which should always do the check), I'll
do the frequency check in repl.BeginRepl instead.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQFZEML6K4X63I4MCHGNDR7EL57ANCNFSM4PQF7VVA>
.
|
odino
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command-line flag (--check-update) for scripted use,
and prompts in the welcome message for the REPL.
Uses https://github.com/tcnksm/go-latest to do the heavy lifting.
Closes #334.