Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for negative indexes in arrays / strings.
[1,2,3][-1] #3
There is one change that might alter existing ABS scripts, and that's
non-existing indexes, for strings, returning an empty string rather than
null
.I believe it's an ok thing to break as both will evaluate to
false
when casted to boolean, and to check whether an index exists one can
simply:
s.len()
)!!s[idx]
)both these examples do not break with these changes. I instead admit
that it would be weird to see code such as:
if s[idx] == null { ... }
rather than
So I guess this is a change that can go through, as it really shouldn't
impact much of the userbase.