Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index assignment gotchas #315

Closed
odino opened this issue Feb 11, 2020 · 1 comment
Closed

Index assignment gotchas #315

odino opened this issue Feb 11, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
1.11.x

Comments

@odino
Copy link
Collaborator

odino commented Feb 11, 2020 

⧐  x = {}; x.y = ""
⧐  x = {}; x.y = "";
 parser errors:
	no prefix parse function for ';' found
	[1:17]	x = {}; x.y = "";
@odino odino added the bug Something isn't working label Feb 11, 2020
@odino odino added this to the 1.11.x milestone Feb 11, 2020
odino added a commit that referenced this issue Feb 11, 2020
@odino
Index / hash assignments gotchas, closes #315
a04f5c2 
They were not properly handling the case where the final
character is a `;`, when they should "consume" it and move
forward. Instead, the parser would parse the assignment and
move onto the next block, which was a single `;`, causing it
to fail.

A better fix for this could be allowing `;` as valid blocks
that are simply ignore, which would also solve expressions
such as `x = 1;;;`, which are now erroring out.
odino added a commit that referenced this issue Feb 11, 2020
@odino
Index / hash assignments gotchas, closes #315
0b4555b 
They were not properly handling the case where the final
character is a `;`, when they should "consume" it and move
forward. Instead, the parser would parse the assignment and
move onto the next block, which was a single `;`, causing it
to fail.

A better fix for this could be allowing `;` as valid blocks
that are simply ignore, which would also solve expressions
such as `x = 1;;;`, which are now erroring out.
odino added a commit that referenced this issue Feb 11, 2020
@odino
Index / hash assignments gotchas, closes #315
c09fc8d 
They were not properly handling the case where the final
character is a `;`, when they should "consume" it and move
forward. Instead, the parser would parse the assignment and
move onto the next block, which was a single `;`, causing it
to fail.

A better fix for this could be allowing `;` as valid blocks
that are simply ignore, which would also solve expressions
such as `x = 1;;;`, which are now erroring out.
@odino
Copy link
Collaborator Author

odino commented Feb 11, 2020

Fixed in 1.10.1

@odino odino closed this as completed Feb 11, 2020
odino added a commit that referenced this issue Feb 11, 2020
@odino
Index / hash assignments gotchas, closes #315
fc8b07d 
They were not properly handling the case where the final
character is a `;`, when they should "consume" it and move
forward. Instead, the parser would parse the assignment and
move onto the next block, which was a single `;`, causing it
to fail.

A better fix for this could be allowing `;` as valid blocks
that are simply ignore, which would also solve expressions
such as `x = 1;;;`, which are now erroring out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.11.x
Development

No branches or pull requests
1 participant
@odino