Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Fix some pylint issues #360

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Fix some pylint issues #360

merged 10 commits into from
Aug 12, 2020

Conversation

michalfabik
Copy link
Contributor

This fixes whitespace issues I ran into while reviewing #356 and some other easy ones.

See commits.

@michalfabik michalfabik requested a review from mgrabovsky August 10, 2020 16:22
xsuchy
xsuchy reviewed Aug 11, 2020
View reviewed changes
retrace-server.spec Outdated Show resolved Hide resolved
@xsuchy
Copy link
Member

xsuchy commented Aug 11, 2020

I am afraid that the last commit ba31850 contains something totally different that the description states. :(

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/abrt-retrace-server-360
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

mgrabovsky
mgrabovsky reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@mgrabovsky mgrabovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed out one minor thing, looks good otherwise.

src/retrace/hooks/hooks.py Outdated Show resolved Hide resolved
@mgrabovsky mgrabovsky merged commit 8e69b5e into abrt:master Aug 12, 2020
@michalfabik michalfabik deleted the pylint branch October 6, 2020 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xsuchy xsuchy xsuchy left review comments

@mgrabovsky mgrabovsky mgrabovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalfabik @xsuchy @mgrabovsky