-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New voicehints for motorway exit #742
base: master
Are you sure you want to change the base?
Conversation
Can you explain what is the difference between the middle "cloud" button and the export button? |
@devemux86 |
@afischerdev |
@@ -26,6 +26,8 @@ public class VoiceHint { | |||
static final int RNLB = 14; // Roundabout left | |||
static final int TU = 15; // 180 degree u-turn | |||
static final int BL = 16; // Beeline routing | |||
static final int EL = 17; // Beeline routing | |||
static final int ER = 18; // Beeline routing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afischerdev The comments here should mention the exit instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks better
@afischerdev Thanks for this implementation. 👍 Does the test server need a restart? |
Just restarted |
Just add a logic that also find motorway exits when there are no more entries. |
Should the clients do something with this? |
@devemux86 |
You mean the 2 new EL + ER instructions. |
@devemux86 |
Thanks @afischerdev , VoiceHint commands 17 EL and 18 ER support will be added to the Locus Map platform. |
This is the PR for #734
The problem with this new voicehints is, not all clients are ready for using.
First rule: the export contains what the clients can read. Means
For testing select you favorite turnInstructionMode.
Please use for a direct test export the button between close and export.
When using JSON export you could select
turnInstructionMode = 2
to get the new index.For OsmAnd exists a special
turnInstructionMode = 8
. This is not reachable via the profile dialog, you have to set this inside the profile editor. It can be used to prepare OsmAnd to the new voicehints before BRouter delivers the new tags onturnInstructionMode = 3
.A Test is possible on the test server: route
@devemux86 @vshcherb @vodie @menion
Please let us know when you change your rules in your apps, so we can go on to normalize the voicehint situation.