-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Dockerfile #647
A Dockerfile #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not firm with Docker, but it looks ok for like it is.
Only I miss is a call for 'generate_profile_variants.sh'
@afischerdev the script was already run by the gradle build but the generated profiles were not used. I updated the Dockerfile and the documentation. Now, if you start the container without mounting a profiles folder, it will use the default profiles including the variants. If you do mount a folder containing custom profiles, it will replace the one with the default profiles. What do you think? |
@joe-akeem BTW for running it on Windows I had to invalidate the first line of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, I think.
So brouter can be run in Docker 😃