-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static code analysis using PMD #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fine helper.
|
I'm not sure why the other PRs are a prerequisite to this PR but I've either merged, commented or closes those PRs. If this PR is merged those PRs that are still open should merge the master to get the ability to run all checks locally instead of getting feedback just from the CI build. |
PMD allows checking code for violation and quickstart provides a ruleset which are "rules that are most likely to apply everywhere". Violated rules are disabled to get started.
afischerdev
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening files with IntelliJ IDEA shows a lot of warnings for our code. This is distracting and makes it hard to see new warnings being added.
PMD and the gradle plugin allow automatic code checks during build (and CI) to prevent new violations from being added.
I've enabled the quickstart ruleset and initially disabled all rules which are currently violated. Re-enabled (and fixed) rules are:
Each rule is a single commit and can be removed I it's deemed to strict.