Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static code analysis using PMD #483

Merged
merged 12 commits into from
Nov 23, 2022
Merged

Conversation

zod
Copy link
Collaborator

@zod zod commented Nov 14, 2022

Opening files with IntelliJ IDEA shows a lot of warnings for our code. This is distracting and makes it hard to see new warnings being added.

PMD and the gradle plugin allow automatic code checks during build (and CI) to prevent new violations from being added.

I've enabled the quickstart ruleset and initially disabled all rules which are currently violated. Re-enabled (and fixed) rules are:

Each rule is a single commit and can be removed I it's deemed to strict.

@zod zod temporarily deployed to BRouter November 14, 2022 06:13 Inactive
@afischerdev
Copy link
Collaborator

Fine helper.
But before we merge this please merge all pending PRs that have no conflicts.

@zod
Copy link
Collaborator Author

zod commented Nov 14, 2022

I'm not sure why the other PRs are a prerequisite to this PR but I've either merged, commented or closes those PRs.

If this PR is merged those PRs that are still open should merge the master to get the ability to run all checks locally instead of getting feedback just from the CI build.

@zod zod temporarily deployed to BRouter November 14, 2022 21:06 Inactive
@afischerdev afischerdev merged commit a764c78 into abrensch:master Nov 23, 2022
@zod zod deleted the code-analysis branch May 17, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants