Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli: Process multiple EfCore ModelBuilder Configure Method when adding a module #8732

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Cli: Process multiple EfCore ModelBuilder Configure Method when adding a module #8732

merged 2 commits into from
Apr 21, 2021

Conversation

yekalkan
Copy link
Member

to allow

            builder.ConfigureCmsKit();
            builder.ConfigureCmsKitPro();

and similar usages.

@yekalkan yekalkan added this to the 4.3-final milestone Apr 21, 2021
@yekalkan yekalkan requested a review from hikalkan April 21, 2021 12:12
@hikalkan
Copy link
Member

Ok, we merge this, but the true solution for cmskit is that: ConfigureCmsKitPro should call ConfigureCmsKit internally.

@hikalkan hikalkan merged commit 6324dfd into rel-4.3 Apr 21, 2021
@hikalkan hikalkan deleted the cli-allow-multiple-EfCoreConfigureMethod branch April 21, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikalkan hikalkan hikalkan approved these changes

Assignees
No one assigned
Labels
abp-cli enhancement
Projects
None yet
Milestone
4.3-final
Development

Successfully merging this pull request may close these issues.
2 participants
@yekalkan @hikalkan