Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to directly enable/disable features on the GlobalFeatureManager #8561

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Allow to directly enable/disable features on the GlobalFeatureManager #8561

merged 2 commits into from
Apr 15, 2021

Conversation

hikalkan
Copy link
Member

@hikalkan hikalkan commented Apr 9, 2021

  • Allowed to create individual features (module-indepdendent) with this commit: 424595b (allows to not derive from the base class)
  • Allow to directly enable/disable features on the GlobalFeatureManager.Instance.
  • Revised the document.
  • Added a TODO at the end, for you to complete.

@hikalkan hikalkan added this to the 4.3-final milestone Apr 9, 2021
@hikalkan hikalkan requested a review from enisn April 9, 2021 14:35
enisn
enisn approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ready to merge after you reviewed the documentation @hikalkan

@enisn enisn merged commit e905b3e into rel-4.3 Apr 15, 2021
@maliming maliming deleted the global-feature-revision branch April 18, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisn enisn enisn approved these changes

Assignees
No one assigned
Labels
abp-framework documentation enhancement
Projects
None yet
Milestone
4.3-final
Development

Successfully merging this pull request may close these issues.
2 participants
@hikalkan @enisn